Re: [PATCH 2/3] usb: mtu3: introduce platform data

[Roman Vivchar]

Hi Angelo,

On Thursday, September 17th, 2026 at 4:41 PM, AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> wrote:

> On 9/17/26 09:32, Roman Vivchar via B4 Relay wrote:
> > From: Roman Vivchar <rva333@xxxxxxxxxxxxxx>
> >
> 
> That's good, but the commit title doesn't explain anything.
> 
> usb: mtu3: Add SoC platform data for FIFO slots ?
> 
> ...or anything else that actually explains what you're doing.

Ack.

> 
> > Some SoCs, such as mt6595, require specific quirks for the MTU3 to
> > function properly.
> >
> > The mt6595 IP block doesn't support multiple slots for the FIFO,
> > resulting FIFO wrap.
> >
> > Fix this by adding platform data with a field to handle FIFO limitation.
> 
> Well, also say that this commit brings no functional differences for the
> currently supported SoCs :-)

Indeed. Will do.

...

> > +	unsigned single_slot:1;
> 
> unsigned fifo_single_slot:1 ?
> 
> ...or you can bring the entire pdata structure in there for easy future extension.
> Your choice.

I don't think it's worth pulling 4 or 8 bytes just for one flag. Let it
be a bitfield for now.

Other comments will be fixed in v2.

Best regards,
Roman