Re: [PATCH net-next v8] net: qualcomm: rmnet: require CAP_NET_ADMIN in the real device netns for config ops
From: patchwork-bot+netdevbpf
Date: Thu Sep 17 2026 - 10:46:22 EST
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@xxxxxxxxxx>:
On Tue, 15 Sep 2026 22:56:42 +0300 you wrote:
> An rmnet device may be created with its real device in a different
> netns than the rmnet device itself (rmnet_newlink() resolves it in
> link_net), and the config paths below only check CAP_NET_ADMIN against
> dev_net(dev), while mutating rmnet port state attached to the real
> device:
>
> - rmnet_changelink() rewrites the endpoint mux table and
> port->data_format and, via rmnet_vnd_update_dev_mtu(), can shrink the
> MTU of the rmnet endpoint netdevs.
> - rmnet_add_bridge() and rmnet_del_bridge(), reachable via
> ndo_add_slave/ndo_del_slave through RTM_SETLINK IFLA_MASTER, flip
> port->rmnet_mode and port->bridge_ep on the real device's port; with
> bridge_ep pointing at a caller-owned device, rmnet_rx_handler() then
> forwards real-device ingress frames to it.
> - rmnet_set_coalesce() rewrites the port aggregation parameters via
> ETHTOOL_SCOALESCE (ioctl) or ETHTOOL_MSG_COALESCE_SET (netlink),
> whose capability checks likewise only cover dev's netns.
>
> [...]
Here is the summary with links:
- [net-next,v8] net: qualcomm: rmnet: require CAP_NET_ADMIN in the real device netns for config ops
https://git.kernel.org/netdev/net-next/c/26ee8cd69d46
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html