Re: [PATCH v3 1/2] platform/x86: intel: wmi: Use sysfs_emit in sbl-fw-update

[Ilpo Järvinen]

On Sat, 22 Aug 2026, svav2021@xxxxxxxxx wrote:

> From: Arav Verma <svav2021@xxxxxxxxx>
> 
> Modernize firmware_update_request_show by replacing legacy
> sprintf() call with sysfs_emit. When altering string,
> corrected format specified from %d to %u to match u32 type of
> target variable.

Hi,

Unfortunately, we cannot accept changes that are not signed off. Please 
see Documentation/process/submitting-patches.rst for more information what 
you certify when signing off a patch and how to do that.

-- 
 i.

> ---
> v3: Resending as v3 due to git send-email formatting error, no code changes have been made.
> 
>  drivers/platform/x86/intel/wmi/sbl-fw-update.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/wmi/sbl-fw-update.c b/drivers/platform/x86/intel/wmi/sbl-fw-update.c
> index 62c9c7f1842ba..cfef71f4f3284 100644
> --- a/drivers/platform/x86/intel/wmi/sbl-fw-update.c
> +++ b/drivers/platform/x86/intel/wmi/sbl-fw-update.c
> @@ -61,7 +61,7 @@ static ssize_t firmware_update_request_show(struct device *dev,
>  	if (ret)
>  		return ret;
>  
> -	return sprintf(buf, "%d\n", val);
> +	return sysfs_emit(buf, "%u\n", val);
>  }
>  
>  static ssize_t firmware_update_request_store(struct device *dev,
> 

-- 
 i.