Re: [PATCH v2 3/7] arm64: dts: freescale: Add Lino iMX93

[Frank Li]

On Thu, Sep 17, 2026 at 04:08:36PM +0200, Francesco Dolcini wrote:
> Hello Frank,
>
> On Mon, Sep 14, 2026 at 04:36:51PM +0200, Francesco Dolcini wrote:
> > On Mon, Sep 14, 2026 at 09:28:13AM -0500, Frank Li wrote:
> > > On Mon, Sep 14, 2026 at 07:42:14AM +0200, Francesco Dolcini wrote:
> > > > Hello Frank,
> > > >
> > > > On Fri, Sep 11, 2026 at 09:30:36AM -0500, Frank Li wrote:
> > > > > On Fri, Sep 11, 2026 at 11:19:46AM +0200, Francesco Dolcini wrote:
> > > > > > From: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> > > > > >
> > > > > > Add support for the Lino iMX93 SoM, its Verdin adapter and development
> > > > > > carrier board.
> > > > > >
> > > > > > The SoM is available in two variants, with i.MX91 or i.MX93 SoC, using
> > > > > > the same PCB (the two chips are pin to pin compatible), to avoid
> > > > > > duplication create a common dtsi to share commonalities.
> > > > > >
> > > > > > Link: https://www.toradex.com/computer-on-modules/lino-arm-family/nxp-imx93
> > > > > > Link: https://www.toradex.com/accessories/lino-verdin-adapter
> > > > > > Link: https://www.toradex.com/products/carrier-board/verdin-development-board-kit
> > > > > > Co-developed-by: Emanuele Ghidoli <emanuele.ghidoli@xxxxxxxxxxx>
> > > > > > Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@xxxxxxxxxxx>
> > > > > > Co-developed-by: Ernest Van Hoecke <ernest.vanhoecke@xxxxxxxxxxx>
> > > > > > Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@xxxxxxxxxxx>
> > > > > > Co-developed-by: Franz Schnyder <franz.schnyder@xxxxxxxxxxx>
> > > > > > Signed-off-by: Franz Schnyder <franz.schnyder@xxxxxxxxxxx>
> > > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> > > >
> > > > ...
> > > >
> > > > > > +&gpio1 {
> > > > > > +	gpio-line-names =
> > > > > > +		"LINO_P18",
> > > > > > +		"LINO_P16",
> > > > > > +		"PMIC_I2C_SCL",
> > > > > > +		"PMIC_I2C_SDA",
> > > > > > +		"",
> > > > > > +		"",
> > > > > > +		"",
> > > > > > +		"",
> > > > > > +		"",
> > > > > > +		"",
> > > > > > +		"LINO_P65", /* 10 */
> > > > > > +		"LINO_S18",
> > > > > > +		"LINO_S24",
> > > > > > +		"LINO_S20",
> > > > > > +		"LINO_S22",
> > > > > > +		"";
> > > > >
> > > > > Can you wrap to 4 names pre line
> > > > >
> > > > > 	gpio-line-names = "LINO_P18", "LINO_P16", "PMIC_I2C_SCL", "PMIC_I2C_SDA",
> > > > > 			  "", "", "", "",
> > > > >
> > > > > Reduce LOC, and easy to locate number, such gpio 13,  second of 3rd line
> > > >
> > > > I already replied on the v1 that I disagree on your request.
> > >
> > > Your v2 sent too quick before I read v1.
> > >
> > > > To me it is
> > > > just more readable the way it is now and I do not see minimizing the
> > > > lines of code something that is bringing any kind of benefit on its own.
> > >
> > > The major concern is that it makes code read harder and lost focus by long
> > > lines.
> >
> > Understood, we do disagree on this.
> >
> > > > Is this blocking this from being picked up?
> > > > Is there any other concern on this series?
> >
> > Can you answer these two questions?
>
> Please let me know if it is a requirement to have the gpio line names
> wrapped with 4 elements per row or not. I am waiting on your answer on
> this.

Although it is not "must" requirement, I think it is easy to read by
packed 4 elements.

Frank

>
> Thanks,
> Francesco
>