Re: [PATCH v5 13/16] fs/resctrl: Deactivate the kernel mode association when a group is removed

[Reinette Chatre]

Hi Babu,

On 9/17/26 12:25 PM, Babu Moger wrote:
> On 9/16/26 00:36, Reinette Chatre wrote:
>> On 8/26/26 12:32 PM, Babu Moger wrote:

...

>>
>>> +        pr_warn("resctrl: kernel mode group not valid\n");
>>
>> Please just fix this file's pr_fmt(fmt) instead.
> 
> 
> Hmm... It looks like we have a pr_fmt(fmt) inconsistency across multiple files.
> 
> Some files use:
> 
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> 
> 
> while others use:
> 
> #define pr_fmt(fmt) "resctrl: " fmt
> 
> > My understanding is that these will produce different log prefixes.
> For example, KBUILD_MODNAME will typically use the object file name,
> whereas "resctrl" provides a consistent subsystem-wide prefix.
> 
> Do you think we should standardize all files to use the same prefix?
> If so, I believe that would be better handled as a separate cleanup
> patch rather than being mixed into this change.
> 

Thanks for catching this. Yes, I think all files should use the same prefix.

Reinette