Re: [PATCH 0/2] drm/nouveau/clk: fix RAM error handling and pstate desync in nvkm_pstate_prog
From: lyude
Date: Thu Sep 17 2026 - 16:59:33 EST
For the whole series:
Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx>
Will push to drm-misc-fixes in just a moment
On Mon, 2026-07-27 at 17:28 +0200, Francesco Magazzu wrote:
> Follow-up to "[PATCH v2 0/4] drm/nouveau: fix list cursor use after
> loop
> in the clk pstate paths"
> (20260712123616.1180830-1-postadelmaga@xxxxxxxxx).
> Sashiko AI review flagged three pre-existing issues while reviewing
> patch
> 2/4 of that series; the third (clk->func->prog()'s error being
> clobbered
> by nvkm_volt_set_id() in nvkm_cstate_prog()) is already fixed by
> patch 4/4
> of that series. These two patches address the other two:
>
> 1. nvkm_pstate_prog() drops the RAM reclock error and falls through
> to
> core clock programming anyway.
> 2. nvkm_pstate_prog() commits clk->pstate to the new state before
> the
> hardware transition has actually succeeded.
>
> Francesco Magazzu (2):
> drm/nouveau/clk: don't ignore RAM clock programming errors in
> nvkm_pstate_prog
> drm/nouveau/clk: only update clk->pstate after hardware programming
> succeeds
>
> nvkm/subdev/clk/base.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)