Re: [PATCH net-next v12 08/15] ax88179_178a: Add EEE configuration support for AX88179A PHYs

[netdev-bot+sashiko]

Thank you for your contribution! Sashiko AI review found 2 potential
issue(s) to consider:

Critical: 0 · High: 0 · Medium: 0 · Low: 2

- [Low] The patch exposes .get_eee/.set_eee (ax88179a_devices.c:209-221,
  table entries at :232-233) and activates the LPI path by populating…
- [Low] The commit message contains a non-existent part number:
  "Configure phylink to work with the PHYs in the AX88197A controllers"…

--

ax88179_178a: Add EEE configuration support for AX88179A PHYs

This adds .get_eee/.set_eee to ax88179a_ethtool_ops, both forwarding to
phylink, and copies supported_interfaces into
phylink_config.lpi_interfaces in ax88179a_phylink_setup() so phylink
considers the MAC LPI capable.

>     ax88179_178a: Add EEE configuration support for AX88179A PHYs
>
>     Configure phylink to work with the PHYs in the AX88197A controllers
>     and provide ethtool get/set eee operations calling into phylink.

[Severity: Low]
Should "AX88197A" read "AX88179A" here?  The driver only knows
AX_VERSION_AX88179A, AX88772D and AX88279, so the part number in the
changelog does not match anything in the tree.

Also, would it help to spell out which variants are affected?
ax88179a_phylink_setup() and ax88179a_ethtool_ops are shared by all three
chips, and dev->net->ethtool_ops = &ax88179a_ethtool_ops is assigned in
ax88179a_bind() without a chip check, so AX88279 gains user-configurable
EEE too, while AX88772D stays unsupported because lpi_capabilities is left
at 0 for it:

	if (!data->is_ax88772d) {
		data->phylink_config.lpi_capabilities = MAC_100FD | MAC_1000FD;
		data->phylink_config.eee_enabled_default = false;
	}

and phylink_ethtool_get_eee()/phylink_ethtool_set_eee() then return
-EOPNOTSUPP for that variant.

Finally, the message says only "configure phylink to work with the PHYs",
which does not mention the actual mechanism being added, namely declaring
the MAC's LPI-capable interfaces so phylink_create() sets
mac_supports_eee.

> diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_devices.c
> index 785919e14e861..6bf1ac17aa1d5 100644
> --- a/drivers/net/usb/ax88179a_devices.c
> +++ b/drivers/net/usb/ax88179a_devices.c
> @@ -206,6 +206,20 @@ static int ax88179a_get_eeprom_len(struct net_device *net)
>  		return AX88179A_EEPROM_LEN;
>  }
>  
> +static int ax88179a_get_eee(struct net_device *net, struct ethtool_keee *edata)
> +{
> +	struct ax88179_data *ax179_data = netdev2data(net);
> +
> +	return phylink_ethtool_get_eee(ax179_data->phylink, edata);
> +}
> +
> +static int ax88179a_set_eee(struct net_device *net, struct ethtool_keee *edata)
> +{
> +	struct ax88179_data *ax179_data = netdev2data(net);
> +
> +	return phylink_ethtool_set_eee(ax179_data->phylink, edata);
> +}
> +

[ ... ]

> @@ -440,6 +456,10 @@ static int ax88179a_phylink_setup(struct usbnet *dev)
>  		phy_if_mode = PHY_INTERFACE_MODE_SGMII;
>  	}
>  
> +	memcpy(data->phylink_config.lpi_interfaces,
> +	       data->phylink_config.supported_interfaces,
> +	       sizeof(data->phylink_config.lpi_interfaces));
> +

[Severity: Low]
This isn't a bug, but what does userspace see for the Tx LPI timer now?

ax88179a_phylink_setup() never assigns phylink_config.lpi_timer_default,
so phylink_create() leaves pl->eee_cfg.tx_lpi_timer at 0, and
ax88179a_get_eee() -> phylink_ethtool_get_eee() reports 0 us via
ethtool --show-eee.

In the other direction, ethtool --set-eee <dev> tx-lpi-timer N goes
through ax88179a_set_eee() -> phylink_ethtool_set_eee() -> eee_to_eeecfg()
which stores the value, but the MAC callback drops it:

	static int ax88179a_mac_enable_tx_lpi(struct phylink_config *config, u32 timer, bool tx_clk_stop)
	{
		struct usbnet *dev = netdev_priv(to_net_dev(config->dev));

		/* AX88179A does not provide LPI timer registers */
		return ax88179_write_cmd(dev, AX_GPHY_CTL, AX_GPHY_EEE_CTRL, true, 0, NULL);
	}

so the value is accepted and echoed back by get_eee without ever reaching
hardware.

For the record, this same combination already exists upstream:
ksz_phylink_get_caps() copies supported_interfaces into lpi_interfaces
without setting lpi_timer_default, and
ksz_phylink_mac_enable_tx_lpi() documents "@timer: timer value before
entering LPI (unused)" and just returns 0.  Would setting
lpi_timer_default to whatever fixed timeout the PHY uses still be worth
doing here, so --show-eee reports something meaningful?

>  	phylink = phylink_create(&data->phylink_config, dev->net->dev.fwnode,
>  				 phy_if_mode, &ax88179a_phylink_mac_ops);
>  	if (IS_ERR(phylink))

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260916-ax88179a-v12-0-60c04c9924a2%40birger-koblitz.de