Re: [PATCH v4 0/3] Convert manual kfree(dev) to put_device()
From: tarunsahu
Date: Thu Sep 17 2026 - 20:38:40 EST
Hello, This is the gentle remind for picking up this series.
Please, let me know if it needs any improvements.
~Tarun
Tarun Sahu <tarunsahu@xxxxxxxxxx> writes:
> Hello,
>
> As per the kernel-doc guidelines, Devices that are tried to register
> with device_register or to add using device_add, must use put_device
> on their failure path (not kfree). This series contains 3 patches
> for updating such instances. Same for kobject_init_and_add or
> kobject_add, call kobject_put instead of kfree in case of error.
>
> V4 <- V3
> 1. Added Fixes tags
> 2. update commit msg as per the suggestion on v3
>
> V3 <- V2
> 1. Updated the commit msg of each patch to mention about the kernel-doc
> guidelines.
>
> V2 <- V1
> 1. Removed patch [1] as it is part of another series [2] already.
>
> [1]: https://lore.kernel.org/all/20260810162814.1398016-4-tarunsahu@xxxxxxxxxx/
> [2]: https://lore.kernel.org/all/20260724171945.2812749-5-shubhrajyoti.datta@xxxxxxx/
>
> Tarun Sahu (3):
> ARM: locomo: Fix device reference leak on registration failure
> firmware: edd: Fix kobject reference leak on registration failure
> powerpc/ps3: use put_device() on device_register() failure in
> ps3_system_bus_device_register
>
> arch/arm/common/locomo.c | 13 ++--
> arch/powerpc/platforms/ps3/device-init.c | 83 ++++++++++++++----------
> arch/powerpc/platforms/ps3/system-bus.c | 2 +
> drivers/firmware/edd.c | 2 +-
> 4 files changed, 59 insertions(+), 41 deletions(-)
>
>
> base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
> --
> 2.55.0.979.g7e5102b832-goog