Re: [PATCH v4 1/3] dt-bindings: soc: qcom: add xiaomi,taoyao-pmic-glink compatible

[Stanislav Zaikin]

On 9/17/26 12:07 PM, Krzysztof Kozlowski wrote:
> On Tue, Sep 15, 2026 at 10:48:59AM +0200, Stanislav Zaikin wrote:
> > Add the compatible string used by Xiaomi 12 Lite 5G (taoyao) so its
> > battery manager can be matched to a device-specific variant in
> > qcom_battmgr.
>
> Previously you were asked if the device is compatible with qcm6490. You
> responded about something completely else - that you need qcm6490. That
> was not the question if you need it or not. The question was are they
> compatible and you have entire commit msg to explain that.
>
> Instead, describing standard Linux device driver matching in commit msg
> is redundant.
>
> Best regards,
> Krzysztof

Yes, apart from battmgr, the pmic-glink implementation on this device is 
compatible with the QCM6490 platform (base communication & UCSI 
implementation), and therefore should keep qcom,qcm6490-pmic-glink and 
qcom,pmic-glink in the compatibles.

I will adjust the commit message in the v5 to:

dt-bindings: soc: qcom: qcom,pmic-glink: Document Xiaomi taoyao compatible

The taoyao is the device compatible with the QCM6490 platform (apart 
from battmgr). The device also requires both UCSI_NO_PARTNER_PDOS & 
UCSI_DELAY_DEVICE_PDOS quirks.

Document the PMIC GLINK firmware interface on the taoyao by using the 
QCM6490 bindings as fallback.

--
Best regards,
Stanislav