Re: [PATCH 2/3] clk: qcom: rcg2: Propagate force-enable status errors

From: Abel Vesa

Date: Fri Sep 18 2026 - 03:59:08 EST


On 26-09-17 11:06:54, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>
> clk_rcg2_is_enabled() returns either a hardware status or a negative
> regmap error. The force-enable polling loop treats every nonzero return as
> an enabled clock, so a failed status read is incorrectly reported as
> success and clock reconfiguration can continue with unknown hardware
> state.
>
> Check for negative returns before testing the enabled status and propagate
> the read error to the caller.
>
> Fixes: 7ef6f11887bd ("clk: qcom: Configure the RCGs to a safe source as needed")
> Assisted-by: LLM
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Reviewed-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>