[PATCH 10/21] media: i2c: it6625: clean up it6625_wait_for_status()

From: Hermes Wu via B4 Relay

Date: Fri Sep 18 2026 - 05:09:39 EST


From: Hermes Wu <Hermes.wu@xxxxxxxxxx>

Use USEC_PER_MSEC instead of a bare 1000 multiplier for the
read_poll_timeout() sleep/timeout arguments, and add the
linux/time64.h include it comes from. Drop the needless (int) cast on
rval, which is already declared int. Downgrade the unconditional
per-call status log from dev_info() to dev_dbg(), since it fires on
every call, not just failures.

Signed-off-by: Hermes Wu <Hermes.wu@xxxxxxxxxx>
---
drivers/media/i2c/it6625.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/media/i2c/it6625.c b/drivers/media/i2c/it6625.c
index bc6b0a9a0bb005b30983a30f8ca685f885ab78c6..b580256d32f51465a620b639fc0134366cc6fcc1 100644
--- a/drivers/media/i2c/it6625.c
+++ b/drivers/media/i2c/it6625.c
@@ -16,6 +16,7 @@
#include <linux/of_graph.h>
#include <linux/regmap.h>
#include <linux/slab.h>
+#include <linux/time64.h>
#include <linux/timer.h>
#include <linux/v4l2-dv-timings.h>
#include <linux/videodev2.h>
@@ -502,11 +503,11 @@ static int it6625_wait_for_status(struct it6625 *it6625, u8 reg, u8 val,
int timeout_round_ms = DIV_ROUND_UP(timeout_ms, sleep_ms) * sleep_ms;

status = read_poll_timeout(it6625_read_byte, rval, rval == val,
- sleep_ms * 1000,
- timeout_round_ms * 1000,
+ sleep_ms * USEC_PER_MSEC,
+ timeout_round_ms * USEC_PER_MSEC,
false, it6625, reg);

- dev_info(dev, "%s status = %d %d", __func__, status, (int)rval);
+ dev_dbg(dev, "%s status = %d %d", __func__, status, rval);
if (status < 0) {
dev_err(dev, "%s err status = %d", __func__, status);
return -ETIMEDOUT;

--
2.34.1