Re: [PATCH 29/48] clk: qcom: gcc-sm8250: Use common clock controller probe data

[Konrad Dybcio]

On 9/16/26 12:28 PM, Abel Vesa wrote:
> Move the always-on branch register offsets into a critical_cbcrs array,
> describe the DFS RCGs through qcom_cc_driver_data and move the register
> programming into the clk_regs_configure callback.
> 
> Use qcom_cc_probe() to perform the common initialization instead of
> open-coding it in the driver's probe.
> 
> Assisted-by: LLM
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
> ---

[...]

> +static void gcc_sm8250_regs_configure(struct device *dev, struct regmap *regmap)
> +{
> +	/*
> +	 * Disable the GPLL0 active input to NPU and GPU
> +	 * via MISC registers.
> +	 */
> +	regmap_update_bits(regmap, 0x4d110, 0x3, 0x3);
> +	regmap_update_bits(regmap, 0x71028, 0x3, 0x3);

Tell the robot to do another pass, using regmap_set/clear_bits()
where it makes sense

Konrad