Re: [PATCH 4/6] usb: typec: ucsi: ccg: add missing pm_runtime_dont_use_autosuspend() call

[Heikki Krogerus]

On Tue, Sep 15, 2026 at 09:02:21AM +0000, Joshua Crofts wrote:
> ucsi_ccg_remove() disables PM runtime on teardown, but doesn't call
> pm_runtime_dont_use_autosuspend(), causing resource leaks.
> 
> Add the missing pm_runtime_dont_use_autosuspend() call.
> 
> Found using Coccinelle.
> 
> Fixes: a94ecde41f7e ("usb: typec: ucsi: ccg: enable runtime pm support")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
>  drivers/usb/typec/ucsi/ucsi_ccg.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c
> index 91c2958a708c..9d3ebb255de7 100644
> --- a/drivers/usb/typec/ucsi/ucsi_ccg.c
> +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c
> @@ -1519,6 +1519,7 @@ static void ucsi_ccg_remove(struct i2c_client *client)
>  
>  	cancel_work_sync(&uc->pm_work);
>  	cancel_work_sync(&uc->work);
> +	pm_runtime_dont_use_autosuspend(uc->dev);
>  	pm_runtime_disable(uc->dev);
>  	ucsi_unregister(uc->ucsi);
>  	free_irq(uc->irq, uc);
> -- 
> 2.47.3

-- 
heikki