Re: [PATCH v8 00/11] arm64: dts: renesas: Add various SolidRun RZ/G2 based boards

[Josua Mayer]

Am 04.09.26 um 13:56 schrieb Josua Mayer:
> Add support for a variety of SolidRun RZ/G2 based SoMs and both
> HummingBoard IIoT and HummingBoard Ripple Evaluation boards.
>
> Bindings are added for all SolidRun RZ/G2 SoMs:
>
> - RZ/G2L SYSTEM ON MODULE
>    https://www.solid-run.com/embedded-industrial-iot/renesas-rz-family/rz-g2l-som/
> - RZ/V2L SYSTEM ON MODULE
>    https://www.solid-run.com/embedded-industrial-iot/renesas-rz-family/rz-v2l-som/
> - RZ/G2LC SYSTEM ON MODULE
>    https://www.solid-run.com/embedded-industrial-iot/renesas-rz-family/rz-g2lc-som/
> - RZ/G2UL SYSTEM ON MODULE
>    https://www.solid-run.com/embedded-industrial-iot/renesas-rz-family/rz-g2ul-som/
>
> And each supported carrier board:
>
> - HUMMINGBOARD RZ/G2L IIOT
>    https://www.solid-run.com/embedded-industrial-iot/renesas-rz-family/hummingboard-rz-series-sbcs/hummingboard-rz-g2l-iot-sbc/
> - HUMMINGBOARD RZ/G2L PRO
>    https://www.solid-run.com/embedded-industrial-iot/renesas-rz-family/hummingboard-rz-series-sbcs/hummingboard-rz-g2l-sbc/
> - HUMMINGBOARD RZ/G2LC BASE (Ripple)
>    https://www.solid-run.com/embedded-industrial-iot/renesas-rz-family/hummingboard-rz-series-sbcs/hummingboard-rz-g2lc-base/
>
> Device-tree are only added for the IIOT and BASE boards to reduce
> initial effort.
>
> Signed-off-by: Josua Mayer <josua@xxxxxxxxxxxxx>
> ---
> Changes in v8:
> - Added RZ/G2UL SoM.
> - Added HummingBoard Ripple.
> - Added SoM Bluetooth nodes.
> - Fixed renesas pinctrl binding commit message logical inversion.
>    (Reported-by: Linus Walleij <linusw@xxxxxxxxxx>)
> - Changed memory start address as suggested by sashiko,
>    and clarified reasoning with comments.
> - Dropped invalid fixed-clock from g2l som.
> - Sorted reserved-mem nodes by address.
> - Split eMMC pinconf nodes supporting input-enable only on data pins,
>    not on clk. Tested both microSD and eMMC overlays (v7 only tested
>    microSD).
> - Made capitalisation of "HummingBoard" consistent in commit messages.
> - Clarified G2LC SoM has 100Mbps ethernet only.
> - Added reg property to dsi panel overlay port node, reported by
>    sashiko.
> - Collected review tags.
> - Extended rzg2l-pinctrl to allow both input-enable and output-enable as
>    requested by Geert, kept Linus' Reviewed-by from previous version.
> - v7 was sent with "v4" subject by mistake, resolved with v8.
> - Link to v7: https://lore.kernel.org/r/20260902-rzg2-sr-boards-v4-0-4a456a422fee@xxxxxxxxxxxxx
>
> Changes in v7:
> - rebased and tested on v7.3-rc1
> - updated explanation for edge-triggered interrupt between SoC and gpio
>    expander.
> - set interrupt for ethernet phys to falling-edge because SoC does not
>    support level interrupts on its gpios, only on dedicated irq pins.
> - Fixed sd data4-7 pinconf nodes trying to avoid cross 1.8V/3.3V domain
>    conflicts when data0-3 are muxed to SD and 4-7 still hard-wired to
>    eMMC. RZ/G2 family does not support bias-disable property, and
>    power-source property applies to all pins of SD0 as a group.
>    Instead added input-disable as the only feasible measure on
>    fixed-function pins.
> - Update dt-binding for rzg2l pinctrl to allow setting input-disable
>    property.
>
> Changes in v6:
> - Drop currently unused usb-vbus pinctrl nodes from som dtsi, reported
>    by sashiko.
> - Fix duplicate pin config mistakes in split dat0-3/dat4-7, reported by
>    sashiko.
> - Link to v5: https://patch.msgid.link/20260809-rzg2-sr-boards-v5-0-19c662358e36@xxxxxxxxxxxxx
>
> Changes in v5:
> - Clarified sdhi mux dt comment on mux and gpio states.
> - Added microsd & emmc dtbos to Makefile targets explicitly for V2L SoC
>    too. Reported by Sashiko.
> - split 8-bit and 4-bit sdhi pinctrl to avoid theoretical overvoltage on
>    hardwired eMMC DAT4-7 pins. Reported by sashiko.
> - Moved dr_mode from usb phy to controller. Reported by sashiko.
> - Collected acks.
> - Link to v4: https://patch.msgid.link/20260730-rzg2-sr-boards-v4-0-08bc459578dc@xxxxxxxxxxxxx
>
> Changes in v4:
> - Rebased on v7.2-rc1.
> - Addresed sashiko comments for g2l som & hb-iiot:
>    gpio dt property -> plural, irq levels, memory size, usb-3.0 hub.
>    The usb hub ids however are correct, 6502 and 6506 are usb-2.0.
> - Addressed sashiko comments for g2lc som & hb-iiot:
>    gpio dt property -> plural, vmmc gpio polarity.
> - Link to v3: https://patch.msgid.link/20260512-rzg2-sr-boards-v3-0-f033fc96c906@xxxxxxxxxxxxx
>
> Changes in v3:
> - Added explanatory comments on won't-fix sashiko findings.
> - Added cap-sdio-irq to sdhi controllers used for WiFi.
> - Drop redundant addition of common device-tree overlays to install
>    targets of G2L(C) SoC.
> - Add common device-tree overlays to install targets of both G2L and V2L
>    SoCs.
> - Assign kbuild composie variables with := operator.
> - Link to v2: https://lore.kernel.org/r/20260511-rzg2-sr-boards-v2-0-82aebbd27891@xxxxxxxxxxxxx
>
> Changes in v2:
> - Added relevant product page links to each commit description.
> - Added product page links to cover letter, thanks Geert.
> - Link to v1: https://lore.kernel.org/r/20260503-rzg2-sr-boards-v1-0-8545677f93ca@xxxxxxxxxxxxx
>
> ---
> Josua Mayer (11):
>        dt-bindings: soc: renesas: Add various SolidRun RZ/G2 based boards
>        dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Allow input-/output-disable
>        dt-bindings: usb: cypress,hx3: make peer-hub property optional
>        arm64: dts: renesas: add support for solidrun rzg2l som and hb-iiot evb
>        arm64: dts: renesas: add support for solidrun rzv2l som and hb-iiot evb
>        arm64: dts: renesas: add support for solidrun rzg2lc som and hb-iiot evb
>        arm64: dts: renesas: rzg2l(c)/rzv2l hb-iiot: add dsi panel dt overlay
>        arm64: dts: renesas: add support for solidrun hb-ripple with rzg2l som
>        arm64: dts: renesas: add support for solidrun hb-ripple with rzv2l som
>        arm64: dts: renesas: add support for solidrun hb-ripple with rzg2lc som
>        arm64: dts: renesas: add support for solidrun rzg2ul som on hb-ripple
>
>   .../bindings/pinctrl/renesas,rzg2l-pinctrl.yaml    |   2 +
>   .../devicetree/bindings/soc/renesas/renesas.yaml   |  37 ++
>   .../devicetree/bindings/usb/cypress,hx3.yaml       |   1 -
>   arch/arm64/boot/dts/renesas/Makefile               |  73 ++-
>   .../renesas/r9a07g043u12-hummingboard-ripple.dts   |  91 ++++
>   .../dts/renesas/r9a07g044c2-hummingboard-iiot.dts  |  20 +
>   .../renesas/r9a07g044c2-hummingboard-ripple.dts    |  95 ++++
>   .../dts/renesas/r9a07g044l2-hummingboard-iiot.dts  |  16 +
>   .../renesas/r9a07g044l2-hummingboard-ripple.dts    |  16 +
>   .../dts/renesas/r9a07g054l2-hummingboard-iiot.dts  |  16 +
>   .../renesas/r9a07g054l2-hummingboard-ripple.dts    |  16 +
>   .../renesas/rzg2l-hummingboard-iiot-common.dtsi    | 564 +++++++++++++++++++++
>   .../renesas/rzg2l-hummingboard-iiot-microsd.dtso   |  26 +
>   ...hummingboard-iiot-panel-dsi-WJ70N3TYJHMNG0.dtso |  79 +++
>   .../renesas/rzg2l-hummingboard-iiot-rs485-a.dtso   |  17 +
>   .../renesas/rzg2l-hummingboard-iiot-rs485-b.dtso   |  17 +
>   .../boot/dts/renesas/rzg2l-hummingboard-iiot.dtsi  |  49 ++
>   .../renesas/rzg2l-hummingboard-pulse-common.dtsi   | 114 +++++
>   .../rzg2l-hummingboard-pulse-micro-hdmi.dtsi       |  79 +++
>   .../dts/renesas/rzg2l-hummingboard-ripple.dtsi     | 127 +++++
>   arch/arm64/boot/dts/renesas/rzg2l-sr-som-emmc.dtso |  44 ++
>   arch/arm64/boot/dts/renesas/rzg2l-sr-som.dtsi      | 480 ++++++++++++++++++
>   .../renesas/rzg2lc-hummingboard-pulse-leds.dtso    |  48 ++
>   arch/arm64/boot/dts/renesas/rzg2lc-sr-som.dtsi     | 442 ++++++++++++++++
>   .../renesas/rzg2ul-hummingboard-pulse-leds.dtso    |  48 ++
>   arch/arm64/boot/dts/renesas/rzg2ul-sr-som.dtsi     | 437 ++++++++++++++++
>   26 files changed, 2952 insertions(+), 2 deletions(-)
> ---
> base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
> change-id: 20260502-rzg2-sr-boards-37d556668a2d
>
> Best regards,

This series has undergone many iterations mostly driven by Sashiko alone.

I was hoping for some human review on the dts parts before re-submitting.
Anything holding up this series? Any guidance?

We are planning to submit RZ/V2N based boards too, and the older SoCs
in this series were the testing ground on upstream acceptance.


Sashiko had two minor nits on this series:

Patch 7: using ronbo compatible string when panel vendor is winstar.

The *only* in-tree user of the compatible is:
arch/arm64/boot/dts/freescale/imx8mp-hummingboard-iiot-panel-dsi-WJ70N3TYJHMNG0.dtso: 
          /* This is a Winstar panel, but the ronbo panel uses same 
controls. */
arch/arm64/boot/dts/freescale/imx8mp-hummingboard-iiot-panel-dsi-WJ70N3TYJHMNG0.dtso: 
          compatible = "ronbo,rb070d30";

So I still feel it unnecessary to add a different vendor for name sake only.
Maintainers please correct me if necessary.


Patch 8: which specific dtsi file should include <dt-bindings/leds/common.h>

Minor and easy to fix.