Re: [PATCH v5 08/17] LoongArch: kexec_file: Fix a modified_cmdline leak

[sashiko-bot]

> load_other_segments() allocates modified_cmdline and stores it in
> image->arch.cmdline_ptr.  machine_kexec_prepare() then copies it to
> KEXEC_CMDLINE_ADDR and overwrites the pointer, so the heap buffer is
> leaked on every successful kexec_file_load().
> 
> Free the buffer after the copy.
> 
> Cc: Huacai Chen <chenhuacai@xxxxxxxxxx>
> Cc: WANG Xuerui <kernel@xxxxxxxxxx>
> Cc: Kexin Liu <liukexin@xxxxxxxxxx>
> Cc: Youling Tang <tangyouling@xxxxxxxxxx>
> Cc: Qiang Ma <maqianga@xxxxxxxxxxxxx>
> Cc: Tianyang Zhang <zhangtianyang@xxxxxxxxxxx>
> Cc: George Guo <guodongtai@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: d162feec6b6e ("LoongArch: Add preparatory infrastructure for kexec_file")
> Signed-off-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918100442.3841135-1-ruanjinjie@xxxxxxxxxx?part=8