Re: [PATCH] of: unittest: Fix of_symbols reference leak in of_unittest_overlay_high_level()
From: Krzysztof Kozlowski
Date: Fri Sep 18 2026 - 07:54:47 EST
On Thu, Sep 17, 2026 at 12:57:17PM +0000, Wentao Liang wrote:
> of_get_child_by_name() returns a node with an elevated reference count,
> but the function never drops it: neither on the early return for an
> illegal node name, nor on the normal return, nor on the err_unlock
> path. Add the missing of_node_put() calls.
>
> Fixes: 81d0848fc8d2 ("of: Add unit tests for applying overlays")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>
Why are you sending 10 separate patches, one by one, not a proper
patchset? It's the same as with Guangshuo Li.
Look:
https://lore.kernel.org/all/?q=f%3AWentao+Liang+%3Cvulab%40iscas.ac.cn%3E
Absolutely nothing is threaded. No way for a subsystem maintainer to for
example drop one comment for entire subsystem. Instead you ask
maintainer to reply TO EACH of the patches.
Best regards,
Krzysztof