Re: [PATCH v2 1/4] dt-bindings: crypto: ti,omap4-des: Remove redundant clock properties
From: Andreas Kemnade
Date: Fri Sep 18 2026 - 08:32:01 EST
On Fri, 18 Sep 2026 10:46:57 +0200
Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> On Wed, Sep 16, 2026 at 02:29:38AM +0530, Bhargav Joshi wrote:
> > The omap-des driver doesn't use the clocks and clock-names properties
> > because clock management is entirely handled by the parent ti-sysc
> > wrapper. files omap5-l4.dtsi, omap4-l4.dtsi, am4372.dtsi doesn't use
> > these properties either.
>
First a simple idea about reasoning here. Start with the assumption that
Linux does not exist and there are random operating systems. using devicetree.
Try to justify your patch that way.
> This is not a correct reason alone to make a DT change and it is
> explicitly documented in writing bindings doc. If hardware has clocks,
> but driver does not use them, they must be documented.
>
This is a lot about how to define several things.
Hardware is described by splitting them into some power management part
(compatible "ti-sysc") as parent and the main part. Basic clocking is
described in that ti-sysc part.
But the situation is a bit different here. The clock to be removed is
different from the stuff in the ti-sysc part. So it needs indeed some more
arguing.
Regards,
Andreas