Re: [PATCH 3/3] regulator: add regulator driver for the Nexperia NEX10000UB

[Neil Armstrong]

On 9/18/26 12:12, Mark Brown wrote:
> On Fri, Sep 18, 2026 at 09:25:39AM +0200, Neil Armstrong wrote:
> > Add regulator support for the Nexperia NEX10000UB dual output LCD
> > bias power supply which provides programmable positive and negative
> > output voltages mainly for display panels applications.
>
> > +static int nex10000ub_of_parse_cb(struct device_node *np,
> > +				  const struct regulator_desc *desc,
> > +				  struct regulator_config *config)
> > +{
> > +	struct gpio_desc *ena_gpiod;
> > +
> > +	ena_gpiod = fwnode_gpiod_get_index(of_fwnode_handle(np), "enable", 0,
> > +					   GPIOD_ASIS, desc->name);
>
> This is GPIOD_ASIS so the direction might not have been configured.

Will fix

> > +	if (IS_ERR(ena_gpiod))
> > +		return PTR_ERR(ena_gpiod);
>
> The binding says the property is optional.

Good catch, forgot to make it mandatory.

Thanks,
Neil