Re: [PATCH v2 01/19] dt-bindings: clock: qcom: Add MSM8952 global clock controller

[Muzaffer Kadir]

Hi Krzysztof,

On Fri, 18 Sep 2026 12:02:02 +0200, Krzysztof Kozlowski wrote:
> On Wed, Sep 16, 2026 at 05:22:06PM +0300, Muzaffer Kadir wrote:
>> Add a device tree binding to describe clocks, resets and power domains
>> provided by the global clock controller on MSM8952 SoC.
>>
>> Signed-off-by: Muzaffer Kadir <muzafferkadir@xxxxxxxxxxxxxx>
> 
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.
> 

Then I will ask a few things,

WARNING: DT binding headers should be licensed (GPL-2.0-only OR .*)
#88: FILE: include/dt-bindings/clock/qcom,gcc-msm8952.h:1:
+/* SPDX-License-Identifier: GPL-2.0-only */

As I said on cover, I originally based on msm8939 gcc,
would it cause license problems with file if I fix this
warning?

Some patches say "has style problems, please review."
Is this related to formatting of code inside patch ?

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#16: 
[1] https://android.googlesource.com/kernel/msm.git/+/refs/tags/android-wear-7.0.0_r0.3/drivers/clk/qcom/clock-gcc-8952.c

Should I move these to "Link:" to fix this type of warnings?
Wouldn't moving them cause a bit understanding loss?

grep: warning: stray \ before -
What does this mean ?

Thanks

>> ---
>>  .../bindings/clock/qcom,gcc-msm8952.yaml           |  56 ++++++
>>  include/dt-bindings/clock/qcom,gcc-msm8952.h       | 217 +++++++++++++++++++++
>>  2 files changed, 273 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-msm8952.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8952.yaml
>> new file mode 100644
>> index 000000000000..274dde633e17
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8952.yaml
>> @@ -0,0 +1,56 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/clock/qcom,gcc-msm8952.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Global Clock & Reset Controller on MSM8952
>> +
>> +maintainers:
>> +  - Muzaffer Kadir <muzafferkadir@xxxxxxxxxxxxxx>
>> +
>> +description: |
>> +  Qualcomm global clock control module provides the clocks, resets and power
>> +  domains on MSM8952.
>> +
>> +  See also::
> 
> git grep "also::" -- Documentation/devicetree/bindings/clock/
> 
> I asked you month ago here:
> <e3fb3794-ca7a-4794-8036-b69e563aaa57@xxxxxxxxxx>
> to not work on old forks.
> 
> Old fork which you should not use is postmarketos, lineageos, whatever
> Android fork kernel, and whatever other tree which is not upstream from
> kernel.org.

I created all of this before sending pinctrl. I tried to clean up by
reading others in upstream before sending but I guess I didn't
noticed that, sorry about that.
I didn't reused fork and mainly used upstream after your reply.

Best regards,
Muzaffer Kadir