Re: [PATCH net] octeontx2-af: skip absent MCS blocks in PTP configuration
From: Simon Horman
Date: Fri Sep 18 2026 - 09:15:08 EST
On Mon, Sep 14, 2026 at 01:46:36PM +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider:
>
> Critical: 0 · High: 0 (1) · Medium: 1 · Low: 0
>
> - [Medium] The CNF10K-B branch of rvu_mcs_ptp_cfg() uses the CGX/RPM
> index directly as the MCS block id: rvu_cgx_ptp_rx_cfg() obtains…
>
> Pre-existing issues:
> - [High] mcs_get_pdata() walks the file-global mcs_list with no lock, no
> RCU and no reference counting, while mcs_probe() inserts entries with…
Hi Slavin,
There is an expectation that AI-generated reviews forwarded to
the netdev ML are responded to. That can take a variety of forms
including an email response that agrees with or refutes the review,
or an updated version of the patch with an appropriate changelog.
The expectation is the patch author or submitter handles this.
But in order to move things along, in this case I've taken a look over it.
And it appears to me that both issues warrant addressing in
the context of this patch. Possibly expanding to a patch-set
containing more than a single patch in order to solve one problem per patch.
--
pw-bot: changes-requested