Re: [PATCH v6 2/6] arm64: dts: qcom: Convert to new media orientation definitions

[Laurent Pinchart]

On Fri, Sep 18, 2026 at 12:09:51PM +0100, Kieran Bingham wrote:
> Quoting Kieran Bingham (2026-09-18 11:44:14)
> > From: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
> > 
> > The orientation property for video interface devices now has definitions
> > to prevent hardcoded integer values for the enum options.
> > 
> > Update the users throughout the qualcomm device trees to use the new
> > definitions.
> > 
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx>
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> > Reviewed-by: David Heidelberg <david@xxxxxxx>
> 
> Sashiko has noted that there is another new dts added in dts/qcom since
> I wrote this patch.
> 
> I don't want to invalidate the above reviews by adding another change,
> so I will send the single update to the new file separately as the core
> definitions are already accepted now.
> 
> If someone /really/ wants me to add the change to
> arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi in this patch,
> please let me know.
> 
> it looks like this:
> 
> ----------- arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi -----------
> index 945127dacc82..f86d3e0d51a6 100644
> @@ -3,10 +3,11 @@
>   * Copyright (c) 2022-2024 Jianhua Lu <lujianhua000@xxxxxxxxx>
>   */
> 
>  #include <dt-bindings/arm/qcom,ids.h>
>  #include <dt-bindings/media/video-interfaces.h>
> +#include <dt-bindings/media/video-interface-devices.h>
>  #include <dt-bindings/phy/phy.h>
>  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>  #include <dt-bindings/usb/pd.h>
>  #include "sm8250.dtsi"
>  #include "pm8150.dtsi"
> @@ -571,11 +572,11 @@ camera_front: camera@10 {
>  		reset-gpios = <&tlmm 109 GPIO_ACTIVE_LOW>;
> 
>  		pinctrl-0 = <&cam_mclk3_default &camera_front_active>;
>  		pinctrl-names = "default";
> 
> -		orientation = <0>; /* Front facing */
> +		orientation = <MEDIA_ORIENTATION_FRONT>;
>  		rotation = <270>;
> 
>  		port {
>  			ov8856_front_ep: endpoint {
>  				data-lanes = <1 2>;

I don't mind either way, and I think you can keep the existing R-b tags
if you add that hunk.

> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts         | 3 ++-
> >  arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 3 ++-
> >  arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi         | 3 ++-
> >  3 files changed, 6 insertions(+), 3 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> > index f41ad446a39e..e2b7f1bd05ab 100644
> > --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> > +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> > @@ -13,6 +13,7 @@
> >  #include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
> >  #include <dt-bindings/leds/common.h>
> >  #include <dt-bindings/media/video-interfaces.h>
> > +#include <dt-bindings/media/video-interface-devices.h>
> >  #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
> >  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> >  #include <dt-bindings/sound/qcom,q6asm.h>
> > @@ -701,7 +702,7 @@ camera@10 {
> >                 pinctrl-0 = <&cam_mclk3_default>;
> >                 pinctrl-names = "default";
> >  
> > -               orientation = <0>; /* Front facing */
> > +               orientation = <MEDIA_ORIENTATION_FRONT>;
> >                 rotation = <270>;
> >  
> >                 port {
> > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > index 218573a97785..3b5f6a29e969 100644
> > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > @@ -11,6 +11,7 @@
> >  #include <dt-bindings/input/gpio-keys.h>
> >  #include <dt-bindings/input/input.h>
> >  #include <dt-bindings/leds/common.h>
> > +#include <dt-bindings/media/video-interface-devices.h>
> >  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> >  
> >  #include "sc8280xp.dtsi"
> > @@ -683,7 +684,7 @@ camera@10 {
> >  
> >                 clocks = <&camcc CAMCC_MCLK3_CLK>;
> >  
> > -               orientation = <0>;      /* Front facing */
> > +               orientation = <MEDIA_ORIENTATION_FRONT>;
> >  
> >                 avdd-supply = <&vreg_l6q>;
> >                 dvdd-supply = <&vreg_l2q>;
> > diff --git a/arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi b/arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi
> > index b4854801a5f5..7880d85b52fe 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm670-google-common.dtsi
> > @@ -9,6 +9,7 @@
> >  #include <dt-bindings/gpio/gpio.h>
> >  #include <dt-bindings/input/input.h>
> >  #include <dt-bindings/leds/common.h>
> > +#include <dt-bindings/media/video-interface-devices.h>
> >  #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
> >  #include <dt-bindings/power/qcom-rpmpd.h>
> >  #include "sdm670.dtsi"
> > @@ -460,7 +461,7 @@ camera@1a {
> >                 pinctrl-names = "default";
> >  
> >                 rotation = <270>;
> > -               orientation = <0>;
> > +               orientation = <MEDIA_ORIENTATION_FRONT>;
> >  
> >                 port {
> >                         cam_front_endpoint: endpoint {
> > 

-- 
Regards,

Laurent Pinchart