Re: [PATCH v4 1/3] iomap: add iomap_symlink_write

From: Christoph Hellwig

Date: Fri Sep 18 2026 - 10:09:50 EST


On Wed, Aug 26, 2026 at 02:41:55PM -0700, Jeremy Bingham wrote:
> Add a new iomap_symlink_write function as an iomap based equivalent to
> page_symlink found in fs/namei.c. Part of being that equivalency is
> behaving similarly to page_symlink. This function now expects the same
> len as page_symlink, where len is the length of the null terminated
> target string. The target is still written out without the trailing
> null.
>
> Suggested-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> Suggested-by: Christoph Hellwig <hch@xxxxxxxxxxxxx>
>
> Signed-off-by: Jeremy Bingham <jbingham@xxxxxxxxx>

No empty line before the signoff, please.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>