Re: [PATCH v2] wifi: nxpwifi: bound debugfs output to the allocated page

[Francesco Dolcini]

On 18 September 2026 15:15:36 CEST, Heyang Tan <thy15333007817@xxxxxxx> wrote:
>This patch fixes two page-buffer overflows in the nxpwifi debugfs
>read paths.

The commit message is not written in the way the Linux kernel. Not "this patch fixed ...", but "fix ..." 

In general if you have 2 fixes, I would expect two patches.

Read the Linux kernel doc on how to contribute and look at the previous accepted patches to get a better idea 


>The patch passes:
>
>  git apply --check
>  scripts/checkpatch.pl --no-tree --strict

This info does not belong to the commit message 

>
>checkpatch reports 0 errors, 0 warnings, 0 checks.  I also compiled
>the patched driver on x86_64 with CONFIG_NXPWIFI=m,
>CONFIG_CFG80211=m, and CONFIG_DEBUG_FS=y; the kernel build and both
>nxpwifi.ko and cfg80211.ko completed cleanly with no compiler or
>modpost errors.

This neither.

>
>I do not have nxpwifi hardware or a runtime test environment, so the
>overflow sizes above are static upper-bound estimates and have not
>been reproduced with KASAN.  The practical exposure also depends on
>the debugfs mount mode, as noted above.

Untested patch, written by an LLM ... did you review what the LLM did?

>
>Assisted-by: LLM Codex
This tag is invalid, check the kernel docs. Just Assisted-by: LLM

With that wrote, I did not look at the code

Francesco