Re: [PATCH v3 2/2] platform/x86: uniwill-laptop: Enable kb backlight and lightbar for TUXEDO

From: Werner Sembach

Date: Fri Sep 18 2026 - 10:46:34 EST


Hi,

Am 17.09.26 um 16:45 schrieb Ilpo Järvinen:
On Sat, 22 Aug 2026, Werner Sembach wrote:

Enable EC controlled keyboard backlight across the board for TUXEDO
devices.

This has split up the device descriptors even more, so the "featureset"
naming scheme was dropped in favor of a "generalized board_name" naming
scheme.

Also Stellaris and Polaris Gen3 are now identified by product_sku to split
them up.

Also some TUXEDO devices with lightbar still had the support missing. This
patch completes the list in this point.

Signed-off-by: Werner Sembach <wse@xxxxxxxxxxxxxxxxxxx>
Reviewed-by: Armin Wolf <W_Armin@xxxxxx>
Hi,

Could this change be split such that mechanical large-scale changes such
as descriptor renames are done in own patch?

The descriptor renames are mainly because there are now more descriptors required and most of them after the change only apply to a few Boardnames.

So doing it in 2 steps would either mean:

- Having the old descriptor naming scheme and the new one side by side in one patch because more are needed and the old scheme doesn't make sense for them.

or

- Renaming the old descriptor names to new longer ones, because they apply to many boardnames, first, and then rename them again as soon as they get split up in the next patch.

Because of this connection I think it makes sense to do this atomic in one commit, but ofc I can try 2 commit, probably with version one. Let me know.

Best regards,

Werner