Re: [PATCH] ASoC: codecs: wm8958: Add const to enum texts allocation types

From: Charles Keepax

Date: Fri Sep 18 2026 - 11:01:29 EST


On Thu, Sep 17, 2026 at 02:11:03PM -0700, Kees Cook wrote:
> From: Kees Cook <kees+treewide@xxxxxxxxxx>
>
> In preparation for converting the kmalloc family of allocators to the
> type-aware kmalloc_obj family, we need to make sure that the returned
> type from the allocation matches the type of the variable being
> assigned. (The kmalloc family returns "void *", which can be implicitly
> cast to any pointer type.)
>
> The assigned types of mbc_texts, vss_texts, vss_hpf_texts, and
> enh_eq_texts are "const char **", but the converted allocation types
> would be "char **", which is the same type without the const qualifier.
> As there is no general way to safely add const qualifiers, take the
> sizes from the assignment targets instead. No change in allocation size
> results.
>
> Build tested ARCH=x86_64 allmodconfig with GCC 16.2.0:
> sound/soc/codecs/wm8958-dsp2.o
>
> Assisted-by: LLM coccinelle
> Signed-off-by: Kees Cook <kees+treewide@xxxxxxxxxx>
> ---

Reviewed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>

Thanks,
Charles