Re: [PATCH v7 0/5] clocksource/timer-econet-en751221: Support irq number per timer

[Daniel Lezcano]

Hi Caleb,

sorry for the delay

On 8/12/26 21:32, Caleb James DeLisle wrote:

> >       |                ^~~~~~~~
> > /home/dlezcano/Work/src/linux/timers/drivers/clocksource/timer-econet- 
> > en751221.c:201:17: note: in expansion of macro ‘pr_err’
> >   201 |                 pr_err("%pOFn: Too many IRQs max %d got %d\n", 
> > np,
> >       |                 ^~~~~~
> > /home/dlezcano/Work/src/linux/timers/include/linux/kern_levels.h:5:25: 
> > warning: format ‘%d’ expects argument of type ‘int’, but argument 3 
> > has type ‘long unsigned int’ [-Wformat=]
> >     5 | #define KERN_SOH        "\001"          /* ASCII Start Of 
> > Header */
> >       |                         ^~~~~~
> > /home/dlezcano/Work/src/linux/timers/include/linux/printk.h:483:25: 
> > note: in definition of macro ‘printk_index_wrap’
> >   483 |                 _p_func(_fmt, ##__VA_ARGS__);         \
> >       |                         ^~~~
> > /home/dlezcano/Work/src/linux/timers/include/linux/printk.h:554:9: 
> > note: in expansion of macro ‘printk’
> >   554 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
> >       |         ^~~~~~
> > /home/dlezcano/Work/src/linux/timers/include/linux/ 
> > kern_levels.h:11:25: note: in expansion of macro ‘KERN_SOH’
> >    11 | #define KERN_ERR        KERN_SOH "3"    /* error conditions */
> >       |                         ^~~~~~~~
> > /home/dlezcano/Work/src/linux/timers/include/linux/printk.h:554:16: 
> > note: in expansion of macro ‘KERN_ERR’
> >   554 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
> >       |                ^~~~~~~~
> > /home/dlezcano/Work/src/linux/timers/drivers/clocksource/timer-econet- 
> > en751221.c:206:17: note: in expansion of macro ‘pr_err’
> >   206 |                 pr_err("%pOFn: Too many regs: max %d got 
> > %d\n", np,
> >       |                 ^~~~~~
>
> I gather you must have built this on a 64 bit machine, so the size_t of 
> ARRAY_SIZE() is a uint64_t (?)

[ ... ]

> Any suggestions would be appreciated.
  s/%d/%zd/ ?