Re: [v2 for-next 2/3] block: allow error injection rules to delay bios

[Haris Iqbal]

On 9/18/26 16:22, Christoph Hellwig wrote:
> On Tue, Sep 15, 2026 at 11:24:47PM +0200, Haris Iqbal wrote:
> > We can do that, but that's only half of the feature, and the weaker half
> > IMHO. Only delay with a successful completion covers a more useful scenario
> > for testing in the upper layers.
> >
> > I am thinking about how else we can do this, but did not find a nice
> > approach.
> >
> > Maybe we can #ifdef the new flag on CONFIG_BLK_ERROR_INJECTION?
>
> At least I'm not worried about the well-predicted flag, but about
> using up the very limited flag space.  But if this is so important
> we'll somehow have to live with it.  I'll take another closer look
> to see if I can come up with a better idea.

Thanks.

I can send a clean v3, with the flag, the changes to 
submit_bio_noacct_nocheck() removed, and the corrections according to 
your comments. I also found the Documentation changes in this version 
were big and explanatory, which I have shortened for v3.