Re: [PATCH] hwmon: hp-wmi-sensors: Fix info_map[] allocation type

From: Guenter Roeck

Date: Fri Sep 18 2026 - 12:11:03 EST


On Thu, Sep 17, 2026 at 02:13:39PM -0700, Kees Cook wrote:
> From: Kees Cook <kees+treewide@xxxxxxxxxx>
>
> In preparation for making the devm_kmalloc family of allocators type
> aware, we need to make sure that the returned type from the allocation
> matches the type of the variable being assigned. (Before, the allocator
> would always return "void *", which can be implicitly cast to any
> pointer type.)
>
> The assigned type of "info_map[type]" is "struct hp_wmi_info **", but
> the converted allocation type would be "struct hp_wmi_info ***", as the
> size was taken from "*info_map", which is one level of indirection too
> many. Luckily both element types are pointers of the same size. Take the
> size from the element type of the assignment target.
>
> Build tested ARCH=x86_64 allmodconfig with GCC 16.2.0:
> drivers/hwmon/hp-wmi-sensors.o
>
> Assisted-by: LLM coccinelle
> Signed-off-by: Kees Cook <kees+treewide@xxxxxxxxxx>
> Acked-by: James Seo <james@xxxxxxxxxx>

Applied.

Thanks,
Guenter