Re: [PATCH v3 2/3] dt-bindings: pps: pps-gpio: document optional pinctrl states

From: Rob Herring

Date: Fri Sep 18 2026 - 12:16:53 EST


On Fri, Sep 18, 2026 at 09:50:06AM +0200, Rodolfo Giometti wrote:
> On Thu, Sep 17, 2026 at 07:56:10AM +0000, Eliav Farber wrote:
> > Document the optional "default" and "inactive" pinctrl-names and show
> > both in the example.
> >
> > Signed-off-by: Eliav Farber <farbere@xxxxxxxxxx>
> > ---
> > diff --git a/Documentation/devicetree/bindings/pps/pps-gpio.yaml b/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> > index 383a838744eb..db6ecb17cb54 100644
> > --- a/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> > +++ b/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> > @@ -28,6 +28,19 @@ properties:
> > description: Indicates a falling edge assert, when present. Rising edge if absent.
> > type: boolean
> >
> > + pinctrl-names:
> > + description:
> > + When the PPS input is muxed through a pin controller, the standard
> > + "default" state selects the PPS/GPIO function and is applied by the
> > + driver core before probe. If a state named "inactive" is also present,
> > + it is selected when the driver is unbound or the system is shut down,
> > + handing the pins back to their alternate function. The "inactive"
> > + state, if used, requires a "default" state; its position among the
> > + names does not matter.
> > + minItems: 1
> > + contains:
> > + const: default
> > +
> > required:
> > - compatible
> > - gpios
> > @@ -40,8 +53,9 @@ examples:
> >
> > pps {
> > compatible = "pps-gpio";
> > - pinctrl-names = "default";
> > + pinctrl-names = "default", "inactive";
> > pinctrl-0 = <&pinctrl_pps>;
> > + pinctrl-1 = <&pinctrl_pps_inactive>;
> > gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
> > assert-falling-edge;
> > echo-gpios = <&gpio1 27 GPIO_ACTIVE_HIGH>;
>
> I tried:
>
> $ make DT_SCHEMA_FILES=Documentation/devicetree/bindings/pps/pps-gpio.yaml \
> dt_binding_check
>
> and it gave me:
>
> pps-gpio.example.dtb: pps (pps-gpio): pinctrl-names:
> ['default', 'inactive'] is too long
> from schema $id: http://devicetree.org/schemas/pps/pps-gpio.yaml

I can't help you without the schema you used. Sounds like something
wrong with 'items'.

Rob