Re: [PATCH net] selftests: net: fix CONFIG_SYSCTL sort order in configs

[Joel Granados]

On Fri, Sep 18, 2026 at 10:49:30PM +0900, Yuya Kusakabe wrote:
> Commit 8d75c338f0bc ("sysctl: remove CONFIG_PROC_SYSCTL, it just mirrors
> CONFIG_SYSCTL") renamed CONFIG_PROC_SYSCTL to CONFIG_SYSCTL in place,
> which left the entry out of alphabetical order in the net and
> packetdrill configs. The netdev CI check for sorted selftest configs
> now fails for every patch that touches either file.
> 
> Fixes: 8d75c338f0bc ("sysctl: remove CONFIG_PROC_SYSCTL, it just mirrors CONFIG_SYSCTL")
> Assisted-by: LLM
> Signed-off-by: Yuya Kusakabe <yuya.kusakabe@xxxxxxxxx>
> ---
>  tools/testing/selftests/net/config             | 2 +-
>  tools/testing/selftests/net/packetdrill/config | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config
> index 30d5fcb09a83..737e7e6327b3 100644
> --- a/tools/testing/selftests/net/config
> +++ b/tools/testing/selftests/net/config
> @@ -118,10 +118,10 @@ CONFIG_NFT_NAT=m
>  CONFIG_NUMA=y
>  CONFIG_OPENVSWITCH=m
>  CONFIG_PAGE_POOL_STATS=y
> -CONFIG_SYSCTL=y
>  CONFIG_PSAMPLE=m
>  CONFIG_RPS=y
>  CONFIG_SYN_COOKIES=y
> +CONFIG_SYSCTL=y
>  CONFIG_SYSFS=y
>  CONFIG_TAP=m
>  CONFIG_TCP_CONG_DCTCP=y
> diff --git a/tools/testing/selftests/net/packetdrill/config b/tools/testing/selftests/net/packetdrill/config
> index 83dde525c53c..b7df8bf30920 100644
> --- a/tools/testing/selftests/net/packetdrill/config
> +++ b/tools/testing/selftests/net/packetdrill/config
> @@ -4,8 +4,8 @@ CONFIG_IPV6=y
>  CONFIG_NET_NS=y
>  CONFIG_NET_SCH_FIFO=y
>  CONFIG_NET_SCH_FQ=y
> -CONFIG_SYSCTL=y
>  CONFIG_SYN_COOKIES=y
> +CONFIG_SYSCTL=y
>  CONFIG_TCP_CONG_CUBIC=y
>  CONFIG_TCP_MD5SIG=y
>  CONFIG_TUN=y
> 
> ---
> base-commit: 46bc52d13594848023e681860df8700c8db14354
> change-id: 20260918-selftests-net-config-sort-4d13ed1f4927
> 
> Best regards,
> --  
> Yuya Kusakabe <yuya.kusakabe@xxxxxxxxx>
> 

This LGTM in the sense that it has no direct consequence for sysctl.
Reviewed-by: Joel Granados <joel.granados@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature