Re: [PATCH net] Revert "net: qrtr: Send HELLO message on endpoint register"

[Manivannan Sadhasivam]

On Fri, Sep 18, 2026 at 06:56:19PM +0200, Thorsten Leemhuis wrote:
> On 9/18/26 18:37, Manivannan Sadhasivam wrote:
> > On Fri, Sep 18, 2026 at 12:16:21PM +0200, Thorsten Leemhuis wrote:
> >> This reverts commit 544d85de4dc22c01badfd8cefa59829ce35c4858.
> >>
> >> It causes suspend and resume problems for numerous people, including
> >> maintainers and developers of ath wifi drivers. A fix was proposed[1],
> >> but did not get any traction, so go for a revert instead.
> >>
> >> Cc: Chris Lew <christopher.lew@xxxxxxxxxxxxxxxx>
> >> Cc: Deepak Kumar Singh <deepak.singh@xxxxxxxxxxxxxxxx>
> >> Cc: Pranav Mahesh Phansalkar <pranav.phansalkar@xxxxxxxxxxxxxxxx>
> >> Reported-by: Daniel J Blueman <daniel@xxxxxxxxx>
> >> Link: https://lore.kernel.org/all/20260909055846.16539-1-daniel@xxxxxxxxx/ [1]
> >> Reported-by: Takashi Iwai <tiwai@xxxxxxx>
> >> Link: https://lore.kernel.org/all/87a4plsg4w.wl-tiwai@xxxxxxx/
> >> Reported-by: Vlastimil Babka <vbabka@xxxxxxxx>
> >> Link: https://lore.kernel.org/all/ab1491bb-cca5-4145-ac7d-31c966abf7b4@xxxxxxxx/
> >> Reported-by: Jeff Johnson <jeff.johnson@xxxxxxxxxxxxxxxx>
> >> Link: https://lore.kernel.org/all/6257c447-788d-4362-851e-0d552bcf7c56@xxxxxxxxxxxxxxxx/
> >> Signed-off-by: Thorsten Leemhuis <linux@xxxxxxxxxxxxx>
> >> ---
> >>
> >> I'm not affected by this, but due to all those reporters mentioned above
> >> it seems it would be good to get this fixed for 7.3-rc4, as Linus' rule
> >> of thumb wrt to fixing regressions is "generally be 'within a week',
> >> preferably before the next rc". Which is why I currently plan to ask
> >> Linus to pull this directly. If this is a bad idea, just tell me.
> >>
> >> The patch from Daniel linked above[1] could have fixed the problem, but
> >> none of the developers of the culprit or the maintainers for this area
> >> commented on it within a week
> > 
> > Really?
> > https://lore.kernel.org/all/hcr4woicsnz3pbhzlguuwjlego7yli3znhjmsx4cdz66xa74zd@wjtle2yslc4b/
> 
> Apologies, I had forgotten about that one.

Np :)

> > FWIW, I don't mind a revert too, but the comment was misleading.
> Just tell me what you would prefer, you are likely the best one to judge
> here. I just think it would be great to get this resolved for -rc4 and
> your option would really help there. Sounds like you would prefer that
> fix, is that right?
> 

Yes, even if my comment about kernel-doc is not addressed.

Let me ping netdev folks in that thread again.

- Mani

-- 
மணிவண்ணன் சதாசிவம்