Re: [PATCH] platform/x86: acer-wmi: Remove unused platform_profile_support variable
From: Ilpo Järvinen
Date: Fri Sep 18 2026 - 13:36:36 EST
On Wed, 2 Sep 2026, Justin Vargas wrote:
> The platform_profile_support variable is assigned during platform
> profile setup but is never read anywhere in the driver. Remove it.
>
> Assisted-by: Claude:claude-opus-5
> Signed-off-by: Justin Vargas <justinyvar@xxxxxxxxx>
> ---
> Found while reading through the driver. Compile tested only, as this
> is a pure dead-code removal.
>
> hp-wmi.c and asus-wmi.c appear to carry the same unused variable -
> declared and assigned once, never read. All three were converted to
> devm_platform_profile_register() in the same series, which may be where
> the last reader went, though my clone is too shallow to confirm that.
> Happy to send patches for the other two as well if that is useful; I
> left them out here to keep this patch focused on the driver I use.
>
> If the intent was for this variable to be checked somewhere rather than
> removed, let me know and I will send that instead.
Now this is interesting, git grep finds 6 platform_profile_support words
(3 variables in two drivers) and none of them are in use. :-/
I'm not convinced there's going to be any use for any of them, probably
leftover from past. Can you make a series to remove them all, one patch
per driver.
--
i.