Re: [PATCH net 5/8] net: bcmgenet: acquire ring lock with BH disabled in bcmgenet_dump_tx_queue

[Florian Fainelli]

On 9/18/26 03:57, Nicolai Buchwitz wrote:
> Hi Florian
>
> On 18.9.2026 02:07, Florian Fainelli wrote:
> > bcmgenet_dump_tx_queue() is called from bcmgenet_timeout() in process or
> > timer context and acquires ring->lock using spin_lock(). If a softirq
> > such as TX NAPI (bcmgenet_tx_poll()) fires on the same CPU while the lock
> > is held, it will deadlock trying to acquire ring->lock.
>
> AFAIU bcmgenet_timeout() only runs from dev_watchdog(), so BH is already
> disabled and no deadlock?

Yes indeed, not sure what I was on with that.
--
Florian