Re: [PATCH v6 04/18] PCI: Reject unreadable ACS controls in isolation checks
From: Logan Gunthorpe
Date: Fri Sep 18 2026 - 16:05:00 EST
On 2026-09-14 05:22, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxx>
>
> pci_acs_flags_enabled() and the Intel SPT PCH quirk use ACS registers
> without checking config-space read errors. A failed read may leave control
> state indeterminate yet allow the device to satisfy requested isolation
> controls.
>
> Return false when either ACS capability or control state cannot be read.
> An unknown state cannot prove isolation.
>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>
Looks good to me.
Reviewed-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>