Re: [PATCH v2 1/6] MIPS: dec: Only check -msym32 when need compiler

[Maciej W. Rozycki]

On Tue, 22 Apr 2025, WangYuli wrote:

> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index d9057e29bc62..1fffc6cf8b52 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -284,6 +284,7 @@ entry-y				= $(shell $(objtree)/arch/mips/tools/elf-entry vmlinux)
>  cflags-y			+= -I$(srctree)/arch/mips/include/asm/mach-generic
>  drivers-$(CONFIG_PCI)		+= arch/mips/pci/
>  
> +ifdef need-compiler
>  #
>  # Automatically detect the build format. By default we choose
>  # the elf format according to the load address.
> @@ -304,7 +305,8 @@ ifdef CONFIG_64BIT
>        $(error CONFIG_CPU_DADDI_WORKAROUNDS unsupported without -msym32)
>      endif
>    endif
> -endif
> +endif # CONFIG_64BIT
> +endif # need-compiler

 This does what is needed, however can you please follow our convention 
here and use indentation nesting?  Please leave the comment outside (it 
begs for a rewrite for clarity, but that's material for a separate fix).

 So for now this is only:

Tested-by: Maciej W. Rozycki <macro@xxxxxxxxxxx>

  Maciej