Re: [PATCH v2 3/6] MIPS: dec: Create reset.h

[Maciej W. Rozycki]

On Tue, 22 Apr 2025, WangYuli wrote:

> Declare externally used functions in reset.c to resolve compilation
> warnings.

 OK, so I got this sorted independently with commit 0eb77376912e ("MIPS: 
DEC: Fix prototypes for halt/reset handlers").  However there are a couple 
of bits here that I encourage you to resubmit.

> In passing, also correct the include file ordering in setup.c as it
> doesn't merit a separate commit.

 Specifically this stuff, i.e.:

> diff --git a/arch/mips/dec/setup.c b/arch/mips/dec/setup.c
> index 87f0a1436bf9..6b100c7d0633 100644
> --- a/arch/mips/dec/setup.c
> +++ b/arch/mips/dec/setup.c
> @@ -18,10 +18,10 @@
>  #include <linux/memblock.h>
>  #include <linux/param.h>
>  #include <linux/percpu-defs.h>
> +#include <linux/pm.h>
>  #include <linux/sched.h>
>  #include <linux/spinlock.h>
>  #include <linux/types.h>
> -#include <linux/pm.h>
>  
>  #include <asm/addrspace.h>
>  #include <asm/bootinfo.h>

(please always submit one self-contained feature or fix per patch).

> diff --git a/arch/mips/include/asm/dec/reset.h b/arch/mips/include/asm/dec/reset.h
> new file mode 100644
> index 000000000000..c1557b88264c
> --- /dev/null
> +++ b/arch/mips/include/asm/dec/reset.h
> @@ -0,0 +1,20 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Reset a DECstation machine.
> + *
> + * File created to eliminate warnings; copyright from reset.c.
> + *
> + * Copyright (C) 199x  the Anonymous
> + * Copyright (C) 2001, 2002, 2003  Maciej W. Rozycki
> + */
> +
> +#ifndef __ASM_DEC_RESET_H
> +
> +#include <linux/interrupt.h>

 And then also this inclusion (in a separate patch).

  Maciej