Re: [PATCH v6 06/18] PCI/P2PDMA: Document directional ACS routing

[Logan Gunthorpe]

On 2026-09-14 05:22, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxx>
> 
> P2PDMA documentation describes ACS controls as path-wide, although Request
> and Completion controls apply to different transaction directions and only
> affect peer-versus-upstream decisions at the path divergence.
> 
> Document the fixed client and provider roles, the divergence port checked
> for each TLP direction, and the conservative handling of unreadable ACS
> state. Clarify which controls disable_acs_redir changes.
> 
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>
> ---
>  Documentation/admin-guide/kernel-parameters.txt |  9 +++++----
>  Documentation/driver-api/pci/p2pdma.rst         | 13 +++++++++++++
>  2 files changed, 18 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 68647ff4bdd2..43a25f3f94fd 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -5291,10 +5291,11 @@ Kernel parameters
>  		disable_acs_redir=<pci_dev>[; ...]
>  				Specify one or more PCI devices (in the format
>  				specified above) separated by semicolons.
> -				Each device specified will have the PCI ACS
> -				redirect capabilities forced off which will
> -				allow P2P traffic between devices through
> -				bridges without forcing it upstream. Note:
> +				Each device specified will have the PCI ACS P2P
> +				Request Redirect, Completion Redirect, and Egress
> +				Control features forced off. This may allow P2P
> +				traffic through bridges that would otherwise be
> +				redirected upstream. Note:
>  				this removes isolation between devices and
>  				may put more devices in an IOMMU group.

Seems like the new sentence and the following existing note are saying
very similar things. Maybe we could drop the 'Note' and say something like:


"This may allow P2P traffic through bridges that would otherwise be
redirected upstream and thus this removes isolation between devices and
may cause affected devices to share an IOMMU group."


Besides that minor nit:

Reviewed-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>