Re: [PATCH 1/3] media: dt-bindings: add rockchip rk3576 vicap

[Michael Riesch]

Hi Amin,

Thanks for the patch, LGTM!

On 9/15/26 14:27, Amin Gattout wrote:
> Add the compatible for the Video Capture (VICAP) unit of the Rockchip
> RK3576. This variant features five MIPI CSI-2 ports and a connection
> to the image signal processor (ISP). The pixel clock of each MIPI port
> enters the VICAP through a dedicated gate in the clock and reset unit,
> so the variant takes five interface clocks and five interface resets
> in addition to the aclk, hclk and dclk of the other variants.
> 
> Signed-off-by: Amin Gattout <amin.gattout@xxxxxxxxx>

Reviewed-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxx>

Best regards,
Michael

> ---
>  .../bindings/media/rockchip,rk3568-vicap.yaml      | 46 +++++++++++++++++++++-
>  1 file changed, 45 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.yaml
> index 080b64503b1b..b7dfaf3b378d 100644
> --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.yaml
> @@ -15,6 +15,10 @@ description:
>    the data from camera sensors, video decoders, or other companion ICs and
>    transfers it into system main memory by AXI bus.
>  
> +  The Rockchip RK3576 Video Capture (VICAP) is similar to its RK3568
> +  counterpart, but features five MIPI CSI-2 ports and an additional
> +  connection to the image signal processor (ISP) block.
> +
>    The Rockchip RK3588 Video Capture (VICAP) is similar to its RK3568
>    counterpart, but features six MIPI CSI-2 ports and additional connections
>    to the image signal processor (ISP) blocks.
> @@ -23,6 +27,7 @@ properties:
>    compatible:
>      enum:
>        - rockchip,rk3568-vicap
> +      - rockchip,rk3576-vicap
>        - rockchip,rk3588-vicap
>  
>    reg:
> @@ -33,7 +38,7 @@ properties:
>  
>    clocks:
>      minItems: 4
> -    maxItems: 5
> +    maxItems: 8
>  
>    clock-names:
>      items:
> @@ -42,6 +47,9 @@ properties:
>        - const: dclk
>        - const: iclk
>        - const: iclk1
> +      - const: iclk2
> +      - const: iclk3
> +      - const: iclk4
>      minItems: 4
>  
>    iommus:
> @@ -221,6 +229,40 @@ allOf:
>  
>              port@11: false
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: rockchip,rk3576-vicap
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 8
> +
> +        clock-names:
> +          minItems: 8
> +
> +        resets:
> +          minItems: 8
> +          maxItems: 8
> +
> +        reset-names:
> +          items:
> +            - const: arst
> +            - const: hrst
> +            - const: drst
> +            - const: irst0
> +            - const: irst1
> +            - const: irst2
> +            - const: irst3
> +            - const: irst4
> +
> +        ports:
> +          properties:
> +            port@6: false
> +
> +            port@11: false
> +
>    - if:
>        properties:
>          compatible:
> @@ -230,9 +272,11 @@ allOf:
>        properties:
>          clocks:
>            minItems: 5
> +          maxItems: 5
>  
>          clock-names:
>            minItems: 5
> +          maxItems: 5
>  
>          resets:
>            minItems: 9
>