Re: [PATCH v3 13/33] gpu: nova-core: separate the generic falcon bootloader from FWSEC
From: Timur Tabi
Date: Fri Sep 18 2026 - 18:04:21 EST
On Thu, 2026-09-17 at 18:06 -0700, John Hubbard wrote:
>
> diff --git a/drivers/gpu/nova-core/falcon.rs b/drivers/gpu/nova-core/falcon.rs
> index 9015de965a53..04e35cbcb6f0 100644
> --- a/drivers/gpu/nova-core/falcon.rs
> +++ b/drivers/gpu/nova-core/falcon.rs
> @@ -385,6 +385,14 @@ pub(crate) fn new(
> })
> }
>
> + /// Returns the size of this falcon's IMEM in bytes.
> + pub(crate) fn imem_size(&self) -> usize {
> + let blocks =
> +
> usize::from_safe_cast(*self.pfalcon.read(regs::NV_PFALCON_FALCON_HWCFG).imem_size());
Why is this `*self` instead of just `self`?