Re: [PATCH] net: wan: farsync: disable PCI device on removal
From: Jakub Kicinski
Date: Fri Sep 18 2026 - 19:56:07 EST
On Wed, 16 Sep 2026 14:31:18 +0800 Guangshuo Li wrote:
> fst_add_one() calls pci_enable_device() to enable the PCI device. The
> probe failure paths call pci_disable_device() to release the matching
> enable reference, but fst_remove_one() does not disable the device
> after a successful probe.
>
> As a result, the PCI device enable reference remains unbalanced after
> the driver is removed.
>
> Call pci_disable_device() after the existing interrupt, tasklet,
> mapping, DMA and PCI region cleanup to release the enable reference.
>
> This issue was found by manual code inspection.
Ancient stuff, no point.