Re: [PATCH v18 2/7] firmware: arm_rmm: Check for RMI support at init

[Jonathan Cameron]

> Query the RMI version number and check if it is a compatible version.
> The first two feature registers are read and exposed for future code to
> use.
> 
> We only support this for Little Endian kernels, the Big Endian kernel
> support is anyway marked BROKEN and is being removed.

Can we have a small comment here on why the default is y

It's a big thing to opt into by default.  Feels like defconfig
material maybe but not in the Kconfig defaults unless I'm missing
something.


> 
> Signed-off-by: Steven Price <steven.price@xxxxxxx>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>

> diff --git a/drivers/firmware/arm_rmm/Kconfig b/drivers/firmware/arm_rmm/Kconfig
> new file mode 100644
> index 000000000000..82724ee23186
> --- /dev/null
> +++ b/drivers/firmware/arm_rmm/Kconfig
> @@ -0,0 +1,26 @@
> +
> +config ARCH_SUPPORTS_RMM
> +	bool
> +
> +config ARM_RMM_RMI
> +	bool "Realm Management Interface (RMI) Support"
> +	depends on ARCH_SUPPORTS_RMM
> +	default y
Really? Why?

-- 
Jonathan Cameron <jonathan.cameron@xxxxxxxxxxxxxxxx>