Re: [PATCH net-next v5 2/4] rtnetlink: add AF_PACKET multicast dumps
From: Yuyang Huang
Date: Fri Sep 18 2026 - 23:52:06 EST
On Thu, Sep 17, 2026 at 10:49 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Mon, 14 Sep 2026 10:45:37 +0900 Yuyang Huang wrote:
> > net/core/rtnetlink.c | 174 +++++++++++++++++++++++++++++++++++
> > 2 files changed, 175 insertions(+)
>
> I don't think we need another 200 LoC in rtnetlink.c ?
> Especially if we make a precedent for AF_PACKET and someone decides
> to even add more code later.
Agreed the logic doesn't belong to rtnetlink.c, I plan to move it to
net/core/dev_addr_lists.c in patchset v6. It seems the dump logic
should sit next to the dev->mc helpers it walks.
> The AI report about consistency check is probably good to act on as
> well?
Will fix it in patchset v6.