Re: [PATCH v5 4/5] dm crypt: batch a bio segment's sectors via dun()

[Herbert Xu]

On Tue, Jun 30, 2026 at 08:34:30AM +0000, Leonid Ravich wrote:
>
> @@ -1410,7 +1452,9 @@ static int crypt_convert_block_skcipher(struct crypt_config *cc,
>  		memcpy(iv, org_iv, cc->iv_size);
>  	}
>  
> -	skcipher_request_set_crypt(req, sg_in, sg_out, cc->sector_size, iv);
> +	skcipher_request_set_crypt(req, sg_in, sg_out, len, iv);
> +	/* A dun() tfm reads this; a plain skcipher ignores it (len is one sector). */
> +	skcipher_request_set_data_unit_size(req, sector_size);

Is this going to use the generated IV for reading through dm-crypt?
Shouldn't it be using the IV stored on disk instead of generating it
again for reading?

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt