Re: [PATCH v6 1/3] dt-bindings: arm: rockchip: Add FriendlyElec NanoPi R28S

[Jonas Karlman]

Hi,

On 9/14/2026 3:35 PM, 安容 via B4 Relay wrote:
> From: 安容 <HystericalDragons@xxxxxxxxx>
> 
> The NanoPi R28S is a dual gigabit Ethernet router board based on the
> Rockchip RK3528 SoC. It shares its base devicetree with the NanoPi
> Zero2, so list both boards in a single entry.
> 
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Signed-off-by: 安容 <HystericalDragons@xxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 81744fbee9..dc04946db0 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -347,6 +347,13 @@ properties:
>                - friendlyarm,nanopi-r2s-plus
>            - const: rockchip,rk3328
>  
> +      - description: FriendlyElec NanoPi R28S/Zero2

Maybe name this something like 'FriendlyElec NanoPi RK3528 series boards'
to closer match other NanoPi/PC entries? That would also prevents
re-ordering once more when NanoPi NEO3 Plus is added.

Regards,
Jonas

> +        items:
> +          - enum:
> +              - friendlyarm,nanopi-r28s
> +              - friendlyarm,nanopi-zero2
> +          - const: rockchip,rk3528
> +
>        - description: FriendlyElec NanoPi R3S
>          items:
>            - const: friendlyarm,nanopi-r3s
> @@ -388,11 +395,6 @@ properties:
>            - const: friendlyarm,nanopi-r76s
>            - const: rockchip,rk3576
>  
> -      - description: FriendlyElec NanoPi Zero2
> -        items:
> -          - const: friendlyarm,nanopi-zero2
> -          - const: rockchip,rk3528
> -
>        - description: FriendlyElec NanoPC T6 series boards
>          items:
>            - enum:
>