Re: [PATCH 01/10] mm/damon/api: remove NR_DAMOS_FILTER_TYPES
From: SJ Park
Date: Sat Sep 19 2026 - 11:57:31 EST
On Sat, 19 Sep 2026 21:02:30 +0800 Zenghui Yu <zenghui.yu@xxxxxxxxx> wrote:
> On 9/17/26 10:21 PM, SJ Park wrote:
> > Nobody uses NR_DAMOS_FILTER_TYPES. Remove it.
[...]
> Similarly we have more definitions of NR_foo in damon.h:
>
> * @NR_DAMOS_ACTIONS: Total number of DAMOS actions
> * @NR_DAMOS_QUOTA_GOAL_METRICS: Number of DAMOS quota goal metrics.
> * @NR_DAMOS_WMARK_METRICS: Total number of DAMOS watermark metrics
> * @NR_DAMON_OPS: Number of monitoring operations implementations
>
> and only NR_DAMON_OPS is actually used (I checked mm-new). If the
> preference is removing all unused macros, we should probably clean them up
> as well.
Nice findings! Please feel free to post a patch for cleaning those up if you
don't mind!
Thanks,
SJ
[...]