Re: [PATCH 3/3] arm64: dts: marvell: Add Sophos XGS 107w NPU board

[Andrew Lunn]

> The reset line of the switch (CP GPIO2 pin 17) is deliberately not given
> to the mv88e6xxx driver as reset-gpios. The 88E6193X needs about two
> seconds after a reset before it can be used, much longer than the driver
> waits, so the probe would time out.

The obvious question is, why is your 88E6193X special?

I've seen issues when there is an EEPROM attached and it has a lot of
content to setup the switch. But that goes against using DSA, where
you want Linux to control the switch, not a fixed configuration.

> +&cp0_i2c0 {
> +	clock-frequency = <100000>;
> +	status = "okay";
> +
> +	/* Drives the port speed LEDs, which are not described yet */
> +	gpio@20 {

Which port?

> +&cp0_i2c1 {
> +	/* SFP EEPROM (0x50/0x51) */

The addresses are not that simple. When a copper module is inserted,
other addresses are used. The SFP driver assumes it has access to all
addresses on the bus.


  Andrew