Re: [PATCH v6 3/3] arm: dts: altera: add Draeger M48 CPU Module
From: Krzysztof Kozlowski
Date: Sun Sep 20 2026 - 05:54:22 EST
On 20/09/2026 09:59, Petko Manolov wrote:
> On 26-09-18 13:57:22, Krzysztof Kozlowski wrote:
>> On Thu, Sep 17, 2026 at 07:31:56PM +0300, Petko Manolov wrote:
>>> Draeger M48 CPU Module that is built around Altera SoCFPGA.
>>
>> How can you run a CPU module alone? To my knowledge there is only one such
>> case, only one exception, and it was explained by the authors. If this is
>> second, I already asked you to properly explain the hardware in commit msg.
>
> I've described the board/carrier/module/whatever in the cover letter. When i
Cover letters do not matter. We don't read them and they usually do not
end up in the git history. Your commit must stand on its own, not rely
on cover letter.
> put the same text in the commit message Sashiko rejected the patch on the
> grounds that there should be just one CPU architecture there. But there are
> two.
Sashiko cannot reject a patch. Does not have such abilities nor power.
Regardless its comment was right - your description was between
incomplete to confusing.
Best regards,
Krzysztof