Re: [PATCH 02/14] dt-bindings: media: add apple,avd

From: Sofus Forstreuter

Date: Sun Sep 20 2026 - 07:12:41 EST


On Sun, Sep 20, 2026 at 12:08:02PM +0200, Krzysztof Kozlowski wrote:
> On 20/09/2026 09:53, Sofus Forstreuter wrote:
>
> >>> + interrupts:
> >>> + minItems: 2
> >>> + items:
> >>> + - description: mailbox 0
> >>> + - description: mailbox 1
> >>> + - description: mailbox 2
> >>> + - description: mailbox 3
> >>> + - description: flag 0
> >>> + - description: flag 1
> >>> + - description: DMA status
> >>> + description: |
> >>> + Notably there are no decode related interrupts. All decode related
> >>> + interrupts are sent to the CM3.
> >>> +
> >>> +required:
> >>> + - compatible
> >>> + - reg
> >>> + - interrupts
> >>> + - reg-names
> >>> + - iommus
> >>> + - power-domains
> >>> + - resets
> >>> +
> >>
> >> Why properties are unconstrained per each variant? Why are they flexible?
> >>
> >
> > There is no reason for this. I will remove the unused interrupts.
>
> Hardware should be completely described, so if there are interrupts
> there should be here as well. And in DTS. This should not be flexible,
> unless hardware actually is flexible (but rarely is).
>

Understood, i will make them all required and add them to DTS.

Best regards,
Sofus