Re: [PATCH mm-new v2] mm: vmscan: put rotation-missed folios at the LRU tail
From: Barry Song
Date: Mon Sep 21 2026 - 03:00:46 EST
On Mon, Sep 21, 2026 at 2:05 PM Ridong Chen <ridong.chen@xxxxxxxxx> wrote:
[...]
> 3. In move_folios_to_lru, we drop the extra reference and move the folio back to
> the lruvec.
>
> ```
> ...
> if (unlikely(folio_put_testzero(folio))) {
> __folio_clear_lru_flags(folio);
> ...
> }
>
[...]
> Therefore, I believe it should be 'folio_ref_count(folio) ==
> folio_expected_ref_count(folio)', not 'folio_ref_count(folio) ==
> folio_expected_ref_count(folio) + 1'.
>
Yes, you're right. I missed the `folio_put_testzero()` above.
Sorry for the noise.
Best Regards
Barry