Re: [PATCH] power: supply: qcom_battmgr: Report capacity on X1E80100
From: Konrad Dybcio
Date: Mon Sep 21 2026 - 04:56:34 EST
On 9/20/26 9:34 PM, Liviu Nicoara wrote:
> Commit 3f87baacea4d ("power: supply: qcom_battmgr: Report battery
> capacity") added POWER_SUPPLY_PROP_CAPACITY to the SC8280XP battery
> properties, computed from the firmware's charge and last-full values.
> When commit cc3e883a0625 ("power: supply: qcom_battmgr: Add charge
> control support") later gave X1E80100 a property table of its own, the
> table was copied without the capacity property, so X1E80100 machines
> expose energy_now and energy_full but no capacity.
>
> The percentage is already computed for this variant in the shared
> SC8280XP callback; only the property list is missing it. Add it, in the
> same place it sits in the SC8280XP table.
>
> Tested on a Dell XPS 13 9345: capacity reads 94 with energy_now
> 52640000 and energy_full 55540000.
>
> Fixes: cc3e883a0625 ("power: supply: qcom_battmgr: Add charge control support")
> Signed-off-by: Liviu Nicoara <lnicoara@xxxxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
Konrad